flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths
Date Mon, 03 Apr 2017 10:56:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953273#comment-15953273
] 

ASF GitHub Bot commented on FLINK-5090:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r109387164
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -391,9 +395,26 @@ public Task(
     		// finally, create the executing thread, but do not start it
     		executingThread = new Thread(TASK_THREADS_GROUP, this, taskNameWithSubtask);
     
    -		if (this.metrics != null && this.metrics.getIOMetricGroup() != null) {
    -			// add metrics for buffers
    -			this.metrics.getIOMetricGroup().initializeBufferMetrics(this);
    +		// add metrics for buffers
    +		this.metrics.getIOMetricGroup().initializeBufferMetrics(this);
    +
    +		// register detailed network metrics, if configured
    +		if (tmConfig.getBoolean(TaskManagerOptions.NETWORK_DETAILED_METRICS_KEY)) {
    --- End diff --
    
    It would be good to per-emptively move this into the run() method, specifically below
`network.registerTask(this);`, as in #3610. Instantiating them in the constructor can lead
to NullPointerExceptions.


> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
>                 Key: FLINK-5090
>                 URL: https://issues.apache.org/jira/browse/FLINK-5090
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics, Network
>    Affects Versions: 1.1.3
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed metrics about
the length of network input and output queues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message