flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From heytitle <...@git.apache.org>
Subject [GitHub] flink pull request #3779: [FLINK-6382] [gelly] Support all numeric types for...
Date Fri, 28 Apr 2017 20:18:33 GMT
Github user heytitle commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3779#discussion_r114007404
  
    --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/input/GridGraph.java
---
    @@ -82,11 +81,27 @@ public void configure(ParameterTool parameterTool) throws ProgramParametrization
     
     	@Override
     	public String getIdentity() {
    -		return getName() + " (" + dimensions + ")";
    +		return getTypeName() + " " + getName() + " (" + dimensions + ")";
     	}
     
     	@Override
    -	public Graph<LongValue, NullValue, NullValue> create(ExecutionEnvironment env)
{
    +	protected long vertexCount() {
    +		// in Java 8 use Math.multiplyExact(long, long)
    --- End diff --
    
    What is the purpose of this comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message