flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...
Date Fri, 28 Apr 2017 11:20:04 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3785#discussion_r113904383
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
    @@ -68,7 +68,11 @@ public static void shutdown() {
     
     	@Override
     	ResultSubpartition createSubpartition() {
    -		return new SpillableSubpartition(0, mock(ResultPartition.class), ioManager);
    +		ResultPartition parent = mock(ResultPartition.class);
    --- End diff --
    
    Could you make this a static helper method?
    ```java
    private static ResultPartition createMockPartition() {
       ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message