flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #3522: [FLINK-5823] [checkpoints] State Backends also han...
Date Thu, 27 Apr 2017 10:18:52 GMT
Github user StefanRRichter commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
    @@ -213,6 +218,23 @@ public boolean discard(JobStatus jobStatus) throws Exception {
     	void discard() throws Exception {
     		try {
    +			// check if we have a shortcut hook to dispose the state
    +			final StateDisposeHook disposeHook = this.disposeHook;
    +			if (disposeHook != null) {
    +				// fast path!
    --- End diff --
    On a second look, do you think it could even make sense to have the previous behaviour
also encapsulated as a cleanup hook and get rid of the if completely?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message