flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3771: [FLINK-6250] Distinct procTime with Rows boundarie...
Date Wed, 26 Apr 2017 13:23:14 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3771#discussion_r113443466
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
    @@ -296,6 +297,41 @@ class CodeGenerator(
           fields.mkString(", ")
         }
     
    +def genInitialize(existDistinct : Boolean): String = {
    +      
    +      val sig: String = 
    +        j"""
    +           | org.apache.flink.api.common.state.MapState[] distStateList =
    +           |   new org.apache.flink.api.common.state.MapState[ ${distinctAggsFlags.size}
];
    +           | 
    +           |  public void initialize(
    +           |    org.apache.flink.api.common.functions.RuntimeContext ctx
    +           |  )""".stripMargin
    +      if(existDistinct){
    --- End diff --
    
    I think this check and the `existDistinct` can be removed. If all fields are `false`,
we won't generate anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message