flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #3772: [FLINK-5869] [flip-1] Introduce abstraction for Fa...
Date Wed, 26 Apr 2017 09:02:37 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3772#discussion_r113399653
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
---
    @@ -72,6 +72,13 @@
     			.defaultValue(16)
     			.withDeprecatedKeys("job-manager.max-attempts-history-size");
     
    +	/**
    +	 * The maximum number of prior execution attempts kept in history.
    +	 */
    +	public static final ConfigOption<String> EXECUTION_FAILOVER_STRATEGY =
    +		key("jobmanager.execution.failover-strategy")
    +			.defaultValue("full");
    --- End diff --
    
    I don't think we have done that yet, no...
    
    There is a PR to extend the config options to include a description (and generate docs),
it could be an extension there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message