flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3623: [FLINK-6196] [table] Support dynamic schema in Tab...
Date Fri, 21 Apr 2017 13:03:43 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetUserDefinedFunctionITCase.scala
    @@ -117,6 +117,187 @@ class DataSetUserDefinedFunctionITCase(
    +  def testDynamicSchema(): Unit = {
    --- End diff --
    Also, these are many integration tests which all run a full job. 
    Aren't `TableTestBase` sufficient to check if the plan is correctly translated? IMO, we
should have only few integration tests and more unit tests based on `TableTestBase`.
    What do you think?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message