flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...
Date Fri, 21 Apr 2017 10:36:22 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
    @@ -221,6 +221,23 @@ object ProjectionTranslator {
    +  def translateOverWindows(
    +      exprs: Seq[Expression],
    +      overWindows: Array[OverWindow]): Seq[Expression] = {
    --- End diff --
    Add `tableEnv` parameter to identify whether this is a batch or a streaming query. 
    In case of a streaming query, check that `overwindow.orderBy` is an `UnresolvedFieldReference`
and translates `rowtime` to a `RowTime` expression and `proctime` to a `ProcTime` expression.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message