flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...
Date Thu, 20 Apr 2017 22:10:32 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3743#discussion_r112494282
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala
---
    @@ -49,6 +57,128 @@ case class Call(functionName: String, args: Seq[Expression]) extends
Expression
     }
     
     /**
    +  * Over expression for calcite over transform.
    +  *
    +  * @param agg             over-agg expression
    +  * @param aggAlias        agg alias for following `select()` clause.
    +  * @param overWindowAlias over window alias
    +  * @param overWindow      over window
    +  */
    +case class OverCall(
    +    agg: Aggregation,
    +    var aggAlias: Expression,
    +    overWindowAlias: Expression,
    +    var overWindow: OverWindow = null) extends Expression {
    +
    +  private[flink] def as(aggAlias: Expression): OverCall = {
    --- End diff --
    
    `OverCall` should not implement its own `as` method. We should use the regular `Alias`
expression for renaming expressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message