flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...
Date Tue, 18 Apr 2017 22:50:10 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r112078731
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
    @@ -41,14 +41,16 @@ class GroupAggProcessFunction(
         private val aggregates: Array[AggregateFunction[_]],
         private val aggFields: Array[Array[Int]],
         private val groupings: Array[Int],
    -    private val aggregationStateType: RowTypeInfo)
    +    private val aggregationStateType: RowTypeInfo,
    +    private val generateRetraction: Boolean)
       extends ProcessFunction[Row, Row] {
     
       Preconditions.checkNotNull(aggregates)
       Preconditions.checkNotNull(aggFields)
       Preconditions.checkArgument(aggregates.length == aggFields.length)
     
       private var output: Row = _
    +  private var previous: Row = _
    --- End diff --
    
    rename to `previousRow`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message