flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3726: [FLINK-6130] [yarn] Fix Consider calling resourceM...
Date Mon, 17 Apr 2017 11:13:01 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3726#discussion_r111731219
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java
---
    @@ -158,14 +160,16 @@ protected int runApplicationMaster(Configuration config) {
     				jobManagerRunner.start();
     				LOG.debug("Job Manager Runner started");
     
    +				// wait for resource manager to finish and return a value for later to get
    +				future = (Future<?>) resourceManager.getTerminationFuture();
    +
     				// ---- (5) start the web monitor
     				// TODO: add web monitor
     			}
    +			Object object = future.value().get();
     
    -			// wait for resource manager to finish
    -			resourceManager.getTerminationFuture().get();
     			// everything started, we can wait until all is done or the process is killed
    -			LOG.info("YARN Application Master finished");
    +			LOG.info("YARN Application Master finished and the result is " + object.toString());
    --- End diff --
    
    Just another nitpick: the `object` variable could probably use a nicer / more meaningful
name :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message