flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #3711: [FLINK-6286] [script] Fix the hbase command not fo...
Date Thu, 13 Apr 2017 14:08:01 GMT
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3711#discussion_r111397645
  
    --- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
    @@ -310,8 +310,16 @@ fi
     INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}"
     
     if [ -n "${HBASE_CONF_DIR}" ]; then
    -    # Setup the HBase classpath.
    -    INTERNAL_HADOOP_CLASSPATHS="${INTERNAL_HADOOP_CLASSPATHS}:`hbase classpath`"
    +    # Search hbase command in PATH.
    +    HBASE_IN_PATH=$(PATH="${HBASE_HOME}/bin:$PATH" \
    +        which hbase 2>/dev/null)
    +    # Whether the hbase command is found.
    +    if [ -f "${HBASE_IN_PATH}" ]; then
    +        # The hbase command is found, then setup the HBase classpath.
    +        INTERNAL_HADOOP_CLASSPATHS="${INTERNAL_HADOOP_CLASSPATHS}:`${HBASE_IN_PATH} classpath`"
    +    else
    +        echo "The HBASE_IN_PATH is setted but can't setup HBase classpath. Please verify
hbase command exists."
    --- End diff --
    
    Perhaps more like "HBASE_CONF_DIR=\"${HBASE_CONF_DIR}\" is set but 'hbase' command was
not found in \"${HBASE_PATH}\" so classpath could not be updated."? I assumed HBASE_PATH="${HBASE_HOME}/bin:$PATH"
as a local variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message