flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3696: [FLINK-6090] [table] Add RetractionRule at the sta...
Date Wed, 12 Apr 2017 20:11:22 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3696#discussion_r110388774
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRetractionRule.scala
---
    @@ -0,0 +1,341 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.plan.nodes.datastream
    +
    +import org.apache.calcite.plan.{RelOptRule, RelOptRuleCall, RelTraitSet}
    +import org.apache.calcite.plan.RelOptRule._
    +import org.apache.calcite.plan.hep.HepRelVertex
    +import org.apache.calcite.rel.RelNode
    +
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable.ListBuffer
    +
    +/**
    +  * Collection of retraction rules that apply various transformations on DataStreamRel
trees.
    +  * Currently, there are three transformations: InitProcessRule, NeedToRetractProcessRule
and
    +  * AccModeProcessRule. Note: these rules must be called in order (InitProcessRule ->
    +  * NeedToRetractProcessRule -> AccModeProcessRule).
    +  */
    +object DataStreamRetractionRule {
    +
    +  /**
    +    * Singleton rule that init retraction trait inside a [[DataStreamRel]]
    +    */
    +  val INIT_INSTANCE = new InitProcessRule()
    +
    +  /**
    +    * Singleton rule that decide needToRetract property inside a [[DataStreamRel]]
    +    */
    +  val NEEDTORETRACT_INSTANCE = new NeedToRetractProcessRule()
    +
    +  /**
    +    * Singleton rule that decide accMode inside a [[DataStreamRel]]
    +    */
    +  val ACCMODE_INSTANCE = new AccModeProcessRule()
    +
    +  /**
    +    * Get all child RelNodes of a RelNode
    +    * @param topRel The input RelNode
    +    * @return All child nodes
    +    */
    +  def getChildRelNodes(topRel: RelNode): ListBuffer[RelNode] = {
    +    val topRelInputs = new ListBuffer[RelNode]()
    --- End diff --
    
    method can be simplified to `topRel.getInputs.asScala.transform(_.asInstanceOf[HepRelVertex].getCurrentRel)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message