flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a s...
Date Fri, 07 Apr 2017 08:09:05 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3686#discussion_r110337050
  
    --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
    @@ -162,11 +162,11 @@ public void testJDBCInputFormatWithParallelismAndNumericColumnSplitting()
throws
     				if (next == null) {
     					break;
     				}
    -				if(next.getField(0)!=null) { Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
    -				if(next.getField(1)!=null) { Assert.assertEquals("Field 1 should be String", String.class,
next.getField(1).getClass());}
    -				if(next.getField(2)!=null) { Assert.assertEquals("Field 2 should be String", String.class,
next.getField(2).getClass());}
    -				if(next.getField(3)!=null) { Assert.assertEquals("Field 3 should be float", Double.class,
next.getField(3).getClass());}
    -				if(next.getField(4)!=null) { Assert.assertEquals("Field 4 should be int", Integer.class,
next.getField(4).getClass());}
    +				if (next.getField(0) != null) { Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
    --- End diff --
    
    you missed putting the assertions on a new line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message