flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...
Date Thu, 06 Apr 2017 08:28:13 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3683#discussion_r110102292
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala
---
    @@ -350,23 +350,18 @@ class LocalFlinkMiniCluster(
     
       def setMemory(config: Configuration): Unit = {
         // set this only if no memory was pre-configured
    -    if (config.getInteger(ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY, -1) == -1) {
    +    if (config.getLong(TaskManagerOptions.MANAGED_MEMORY_SIZE) == -1L) {
    --- End diff --
    
    If we keep the default at -1 then we should compare against `TaskManagerOptons.MANAGED_MEMORY_SIZE.defaultValue()`;
the same applies to other instances of this pattern.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message