flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #3662: [FLINK-6246] Fix generic type of OutputTag in oper...
Date Mon, 03 Apr 2017 14:21:19 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3662#discussion_r109428555
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
    @@ -619,20 +619,20 @@ public void collect(StreamRecord<T> record) {
     		}
     
     		@Override
    -		public <X> void collect(OutputTag<?> outputTag, StreamRecord<X> record)
{
    +		public <X> void collect(OutputTag<X> outputTag, StreamRecord<X> record)
{
     			for (int i = 0; i < outputs.length - 1; i++) {
     				Output<StreamRecord<T>> output = outputs[i];
     
     				// due to side outputs, StreamRecords of varying types can pass through the broadcasting
     				// collector so we need to cast
     				@SuppressWarnings({"unchecked", "rawtypes"})
    --- End diff --
    
    Suppression not needed anymore. Also the comment is not adequate, as we do not cast anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message