flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3660: [FLINK-6237] [table] support RAND and RAND_INTEGER...
Date Mon, 03 Apr 2017 14:04:21 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3660#discussion_r109423941
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
    @@ -1494,6 +1519,22 @@ class CodeGenerator(
       }
     
       /**
    +    * Adds a reusable [[java.util.Random]] to the member area of the generated [[Function]].
    +    *
    +    * @return member variable term
    +    */
    +  def addReusableRandom(): String = {
    +    val fieldTerm = newName("random")
    +
    +    val field =
    +      s"""
    +         |transient java.util.Random $fieldTerm = null;
    --- End diff --
    
    `Random` implements `Serializable`. I think we initialize `Random` already here, remove
`transient` and add `final`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message