Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1424200C52 for ; Mon, 27 Mar 2017 07:45:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AFD27160B92; Mon, 27 Mar 2017 05:45:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D254E160B87 for ; Mon, 27 Mar 2017 07:45:47 +0200 (CEST) Received: (qmail 34956 invoked by uid 500); 27 Mar 2017 05:45:46 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 34947 invoked by uid 99); 27 Mar 2017 05:45:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Mar 2017 05:45:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 58E7FC20BB for ; Mon, 27 Mar 2017 05:45:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qHEqLj-iJzXH for ; Mon, 27 Mar 2017 05:45:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6F9C45FC6D for ; Mon, 27 Mar 2017 05:45:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 030E7E0D1E for ; Mon, 27 Mar 2017 05:45:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 064B72407D for ; Mon, 27 Mar 2017 05:45:42 +0000 (UTC) Date: Mon, 27 Mar 2017 05:45:42 +0000 (UTC) From: "Tzu-Li (Gordon) Tai (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (FLINK-6190) Write "Serializer Configurations" metainfo along with state MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 27 Mar 2017 05:45:48 -0000 [ https://issues.apache.org/jira/browse/FLINK-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6190: --------------------------------------- Description: In order for serializers to be able to be reconfigured on restore, we need knowledge of the previous serializer configurations, e.g. what types were registered, with which specific / default serializers, and especially for Kryo, the order they were registered. For this, we will need serializer configuration metainfo to be self-contained within the written state. For the implementation, we propose to include the following changes: - Have a new separate {{SerializersConfig}} class that is extracted from {{ExecutionConfig}}. This new class should contain only the serializer-related configurations (e.g., {{registeredKryoTypes}}, {{registeredPojoTypes}}, etc.). The {{SerializersConfig}} class should only be internally used, and therefore annotated with {{Internal}}. Users should still use the {{ExecutionConfig}} to configure serializers. - For serializers that previously require a {{ExecutionConfig}} in constructors, try changing them to take a {{SerializersConfig}} instead. - Introduce {{SerializersConfigSerializationProxy}}, which is in charge of serializing the current {{SerializersConfig}} when writing state to streams. This proxy defines the the serialized format of serializer configurations, therefore should be a {{VersionedIOReadableWritable}} as we may change the format / information written in the future. - Add {{SerializersConfigSerializationProxy}} into state backends serialization proxies (e.g. {{KeyedBackendSerializationProxy}}) so that the serializer configuration is written into state. Need to additionally make sure backwards compatibility of previous-version backend serialization proxies. was: In order for serializers to be able to be reconfigured on restore, we need knowledge of the previous serializer configurations, e.g. what types were registered, with which specific / default serializers, and especially for Kryo, the order they were registered. For this, we will need serializer configuration metainfo to be self-contained within the written state. For the implementation, we propose the following: - Have a new separate {{SerializersConfig}} class that is extracted from {{ExecutionConfig}}. This new class should contain only the serializer-related configurations (e.g., {{registeredKryoTypes}}, {{registeredPojoTypes}}, etc.). - Introduce {{SerializersConfigSerializationProxy}}, which is in charge of serializing the current {{SerializersConfig}} when writing state to streams. This proxy defines the the serialized format of serializer configurations, therefore should be a {{VersionedIOReadableWritable}} as we may change the format / information written in the future. - Add {{SerializersConfigSerializationProxy}} into state backends serialization proxies (e.g. {{KeyedBackendSerializationProxy}}) so that the serializer configuration is written into state. Need to additionally make sure backwards compatibility of previous-version backend serialization proxies. > Write "Serializer Configurations" metainfo along with state > ----------------------------------------------------------- > > Key: FLINK-6190 > URL: https://issues.apache.org/jira/browse/FLINK-6190 > Project: Flink > Issue Type: Sub-task > Components: State Backends, Checkpointing, Type Serialization System > Reporter: Tzu-Li (Gordon) Tai > Assignee: Tzu-Li (Gordon) Tai > > In order for serializers to be able to be reconfigured on restore, we need knowledge of the previous serializer configurations, e.g. what types were registered, with which specific / default serializers, and especially for Kryo, the order they were registered. > For this, we will need serializer configuration metainfo to be self-contained within the written state. > For the implementation, we propose to include the following changes: > - Have a new separate {{SerializersConfig}} class that is extracted from {{ExecutionConfig}}. This new class should contain only the serializer-related configurations (e.g., {{registeredKryoTypes}}, {{registeredPojoTypes}}, etc.). The {{SerializersConfig}} class should only be internally used, and therefore annotated with {{Internal}}. Users should still use the {{ExecutionConfig}} to configure serializers. > - For serializers that previously require a {{ExecutionConfig}} in constructors, try changing them to take a {{SerializersConfig}} instead. > - Introduce {{SerializersConfigSerializationProxy}}, which is in charge of serializing the current {{SerializersConfig}} when writing state to streams. This proxy defines the the serialized format of serializer configurations, therefore should be a {{VersionedIOReadableWritable}} as we may change the format / information written in the future. > - Add {{SerializersConfigSerializationProxy}} into state backends serialization proxies (e.g. {{KeyedBackendSerializationProxy}}) so that the serializer configuration is written into state. Need to additionally make sure backwards compatibility of previous-version backend serialization proxies. -- This message was sent by Atlassian JIRA (v6.3.15#6346)