Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 28 Mar 2017 18:39:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13058953.1490375663000.145727.1490726381634@Atlassian.JIRA>
In-Reply-To: <JIRA.13058953.1490375663000@Atlassian.JIRA>
References: <JIRA.13058953.1490375663000@Atlassian.JIRA> <JIRA.13058953.1490375663860@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6183) TaskMetricGroup may not be cleanup
 when Task.run() is never called or exits early
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 28 Mar 2017 18:39:46 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945700#comment-15945700 ] 

ASF GitHub Bot commented on FLINK-6183:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3610#discussion_r108503328
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java ---
    @@ -80,8 +80,17 @@ public TaskMetricGroup addTask(
     					taskName,
     					subtaskIndex,
     					attemptNumber);
    -				tasks.put(executionAttemptID, task);
    -				return task;
    +				TaskMetricGroup prior = tasks.put(executionAttemptID, task);
    +				if (prior == null) {
    +					return task;
    --- End diff --
    
    yes that would work as well.


> TaskMetricGroup may not be cleanup when Task.run() is never called or exits early
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-6183
>                 URL: https://issues.apache.org/jira/browse/FLINK-6183
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>
> The TaskMetricGroup is created when a Task is created. It is cleaned up at the end of Task.run() in the finally block. If however run() is never called due some failure between the creation and the call to run the metric group is never closed. This also means that the JobMetricGroup is never closed.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)