Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 393BF200C38 for ; Wed, 15 Mar 2017 19:02:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 37D2C160B60; Wed, 15 Mar 2017 18:02:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 89829160B8A for ; Wed, 15 Mar 2017 19:02:47 +0100 (CET) Received: (qmail 57476 invoked by uid 500); 15 Mar 2017 18:02:46 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 57461 invoked by uid 99); 15 Mar 2017 18:02:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 18:02:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F01E91A0943 for ; Wed, 15 Mar 2017 18:02:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lnG_Kl58ZgQC for ; Wed, 15 Mar 2017 18:02:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A7BE35FDD9 for ; Wed, 15 Mar 2017 18:02:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7BD8EE0984 for ; Wed, 15 Mar 2017 18:02:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C77AF243B6 for ; Wed, 15 Mar 2017 18:02:42 +0000 (UTC) Date: Wed, 15 Mar 2017 18:02:42 +0000 (UTC) From: "Bowen Li (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References:

Subject: [jira] [Commented] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Mar 2017 18:02:48 -0000 [ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926665#comment-15926665 ] Bowen Li commented on FLINK-6053: --------------------------------- Cool. Adding a NumberGauge or NumericGauge was my first impression when running into this problem. But not being able to extend AbstractReporter might not be good. I need more time to think through solution. And I appreciate your input! BTW, can you please add me as contributor to this project, so I can assign tickets to myself? > Gauge should only take subclasses of Number, rather than everything > ---------------------------------------------------------------------- > > Key: FLINK-6053 > URL: https://issues.apache.org/jira/browse/FLINK-6053 > Project: Flink > Issue Type: Improvement > Components: Metrics > Affects Versions: 1.2.0 > Reporter: Bowen Li > Fix For: 2.0.0 > > > Currently, Flink's Gauge is defined as > ```java > public interface Gauge extends Metric { > T getValue(); > } > ``` > But it doesn't make sense to have Gauge take generic types other than Number. And it blocks I from finishing FLINK-6013, because I cannot assume Gauge is only about Number. So the class should be like > ```java > public interface Gauge extends Metric { > T getValue(); > } > ``` -- This message was sent by Atlassian JIRA (v6.3.15#6346)