Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 1 Mar 2017 12:42:45 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13041934.1486698791000.29927.1488372165268@Atlassian.JIRA>
In-Reply-To: <JIRA.13041934.1486698791000@Atlassian.JIRA>
References: <JIRA.13041934.1486698791000@Atlassian.JIRA> <JIRA.13041934.1486698791207@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-5768) Apply new aggregation functions for
 datastream and dataset tables
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Mar 2017 12:42:56 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890089#comment-15890089 ] 

ASF GitHub Bot commented on FLINK-5768:
---------------------------------------

Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3423#discussion_r103674711
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala ---
    @@ -0,0 +1,101 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.runtime.aggregate
    +
    +import java.util.{ArrayList => JArrayList, List => JList}
    +import org.apache.flink.api.common.functions.{AggregateFunction => ApiAggFunction}
    +import org.apache.flink.table.functions.{Accumulator, AggregateFunction}
    +import org.apache.flink.types.Row
    +
    +/**
    +  * Aggregate Function used for the aggregate operator in
    +  * [[org.apache.flink.streaming.api.datastream.WindowedStream]]
    +  *
    +  * @param aggregates       the list of all [[org.apache.flink.table.functions.AggregateFunction]]
    +  *                         used for this aggregation
    +  * @param aggFieldsIndex   the position (in the input Row) of the input value for each aggregate
    +  * @param aggregateMapping the list of the mapping of (the position of this aggregate result in the
    +  *                         output row => the index of the aggregate) for all the aggregates
    +  * @param groupKeysIndex   the position (in the input Row) of grouping keys
    +  * @param groupKeysMapping the list of mapping of (the position of the grouping key in the
    +  *                         output row => the index of grouping key) for all the grouping keys
    +  * @param finalRowArity    the arity of the final row
    +  */
    +class AggregateAggFunction(
    +    private val aggregates: Array[AggregateFunction[_]],
    +    private val aggFieldsIndex: Array[Int],
    +    private val aggregateMapping: Array[(Int, Int)],
    +    private val groupKeysIndex: Array[Int],
    --- End diff --
    
    Yes, I agree with you we can move the groupkeys and agg/group mappings to WindowFunction. Since this PR is dedicated to change aggregate API and functions, and we want to merge this asap such that it won't block other aggregate related PR to be merged. Can we refactor this later?


> Apply new aggregation functions for datastream and dataset tables
> -----------------------------------------------------------------
>
>                 Key: FLINK-5768
>                 URL: https://issues.apache.org/jira/browse/FLINK-5768
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> Apply new aggregation functions for datastream and dataset tables
> This includes:
> 1. Change the implementation of the DataStream aggregation runtime code to use new aggregation functions and aggregate dataStream API.
> 2. DataStream will be always running in incremental mode, as explained in 06/Feb/2017 in FLINK5564.
> 2. Change the implementation of the Dataset aggregation runtime code to use new aggregation functions.
> 3. Clean up unused class and method.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)