Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 13 Mar 2017 18:54:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13021552.1479408221000.5551.1489431281624@Atlassian.JIRA>
In-Reply-To: <JIRA.13021552.1479408221000@Atlassian.JIRA>
References: <JIRA.13021552.1479408221000@Atlassian.JIRA> <JIRA.13021552.1479408221307@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-5090) Expose optionally detailed metrics
 about network queue lengths
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 13 Mar 2017 18:54:48 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922726#comment-15922726 ] 

ASF GitHub Bot commented on FLINK-5090:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r105742696
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java ---
    @@ -0,0 +1,168 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.network.partition.consumer;
    +
    +import org.apache.flink.metrics.Gauge;
    +import org.apache.flink.metrics.MetricGroup;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +public class InputGateMetrics {
    +
    +	private final SingleInputGate inputGate;
    +
    +	private long lastTotal = -1;
    +
    +	private int lastMin = -1;
    +
    +	private int lastMax = -1;
    +
    +	private float lastAvg = -1.0f;
    +
    +	// ------------------------------------------------------------------------
    +
    +	private InputGateMetrics(SingleInputGate inputGate) {
    +		this.inputGate = checkNotNull(inputGate);
    +	}
    +
    +	// ------------------------------------------------------------------------
    +
    +	// these methods are package private to make access from the nested classes faster 
    +
    +	long refreshAndGetTotal() {
    +		long total;
    +		if ((total = lastTotal) == -1) {
    +			refresh();
    --- End diff --
    
    I guess the main reason for this was performance in case all (up to) 4 metrics are requested. What's the preferred way of exposing these kind of metrics? Should I gather all 4 in a custom object and enclose that one in a Gauge? How could the metrics then be displayed, e.g. in the web interface?


> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
>                 Key: FLINK-5090
>                 URL: https://issues.apache.org/jira/browse/FLINK-5090
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics, Network
>    Affects Versions: 1.1.3
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed metrics about the length of network input and output queues.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)