Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: StefanRRichter <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3558-flink@git.apache.org>
In-Reply-To: <git-pr-3558-flink@git.apache.org>
Subject: [GitHub] flink pull request #3558: [FLINK-6096][checkpoint] Refactor the migration of...
Content-Type: text/plain
Message-Id: <20170327101047.56B3CDFF66@git1-us-west.apache.org>
Date: Mon, 27 Mar 2017 10:10:47 +0000 (UTC)
archived-at: Mon, 27 Mar 2017 10:10:52 -0000

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3558#discussion_r107908422
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/migration/MigrationInstantiationUtil.java ---
    @@ -0,0 +1,114 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.migration;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.migration.v0.SavepointV0;
    +import org.apache.flink.util.InstantiationUtil;
    +
    +import java.io.ByteArrayInputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.ObjectInputStream;
    +import java.io.ObjectStreamClass;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * Utility class to deserialize legacy classes for migration.
    + */
    +@PublicEvolving
    +public final class MigrationInstantiationUtil {
    +
    +	private static final Map<Integer, Map<String, String>> MigrationMappings = new HashMap<Integer, Map<String, String>>() {{
    --- End diff --
    
    Minor code style comment: we use upper case and underscore for the names of all static final variables in Flink. For example: MIGRATION_MAPPINGS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---