Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: twalthr <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3409-flink@git.apache.org>
In-Reply-To: <git-pr-3409-flink@git.apache.org>
Subject: [GitHub] flink pull request #3409: [flink-5570] [Table API & SQL]Support register ext...
Content-Type: text/plain
Message-Id: <20170320145823.DA850DFFC0@git1-us-west.apache.org>
Date: Mon, 20 Mar 2017 14:58:23 +0000 (UTC)
archived-at: Mon, 20 Mar 2017 14:58:31 -0000

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3409#discussion_r106921052
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala ---
    @@ -178,4 +178,32 @@ class BatchTableEnvironment(
     
         registerTableFunctionInternal[T](name, tf)
       }
    +
    +  /**
    +    * Scans a table from registered temporary tables and registered catalogs.
    +    *
    +    * The table to scan must be registered in the TableEnvironment or
    +    * must exist in registered catalog in the TableEnvironment.
    +    *
    +    * Example:
    +    *
    +    * to scan a registered temporary table
    +    * {{{
    +    *   val tab: Table = tableEnv.scan("tableName")
    +    * }}}
    +    *
    +    * to scan a table from a registered catalog
    +    * {{{
    +    *   val tab: Table = tableEnv.scan("catalogName.dbName.tableName")
    +    * }}}
    +    *
    +    * @param tablePath The path of the table to scan.
    +    * @throws TableException if no table is found using the given table path.
    +    * @return The resulting [[Table]].
    +    */
    +  @throws[TableException]
    +  def scan(tablePath: String): Table = {
    --- End diff --
    
    Why do we have two types of scan methods (one with string and one with var-args)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---