Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: twalthr <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3406-flink@git.apache.org>
In-Reply-To: <git-pr-3406-flink@git.apache.org>
Subject: [GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...
Content-Type: text/plain
Message-Id: <20170316070532.269EDDFBC9@git1-us-west.apache.org>
Date: Thu, 16 Mar 2017 07:05:32 +0000 (UTC)
archived-at: Thu, 16 Mar 2017 07:05:37 -0000

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3406#discussion_r106349244
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala ---
    @@ -0,0 +1,73 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.sources
    +
    +import org.apache.flink.table.annotation.TableType
    +import org.apache.flink.table.catalog.{ExternalCatalogTable, TableSourceConverter}
    +
    +import scala.collection.JavaConverters._
    +import java.util.{Set => JSet}
    +
    +import com.google.common.collect.ImmutableSet
    +
    +/**
    +  * The class defines a converter used to convert [[CsvTableSource]] to
    +  * or from [[ExternalCatalogTable]].
    +  */
    +@TableType(value = "csv")
    +class CsvTableSourceConverter extends TableSourceConverter[CsvTableSource] {
    +
    +  private val required: JSet[String] = ImmutableSet.of("path", "fieldDelim", "rowDelim")
    +
    +  override def requiredProperties: JSet[String] = required
    +
    +  override def fromExternalCatalogTable(
    +      externalCatalogTable: ExternalCatalogTable): CsvTableSource = {
    +    val params = externalCatalogTable.properties.asScala
    +    val csvTableSourceBuilder = new CsvTableSource.Builder
    +
    +    params.get("path").foreach(csvTableSourceBuilder.path)
    +    params.get("fieldDelim").foreach(csvTableSourceBuilder.fieldDelimiter)
    +    params.get("rowDelim").foreach(csvTableSourceBuilder.lineDelimiter)
    +    params.get("quoteCharacter").foreach(quoteStr =>
    +      if (quoteStr.length != 1) {
    +        throw new IllegalArgumentException("the value of param quoteCharacter is invalid")
    --- End diff --
    
    This exception could be improved. "must only contain one character"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---