Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: KurtYoung <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3520-flink@git.apache.org>
In-Reply-To: <git-pr-3520-flink@git.apache.org>
Subject: [GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...
Content-Type: text/plain
Message-Id: <20170316024732.7A3B3DFE7B@git1-us-west.apache.org>
Date: Thu, 16 Mar 2017 02:47:32 +0000 (UTC)
archived-at: Thu, 16 Mar 2017 02:47:37 -0000

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3520#discussion_r106329099
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala ---
    @@ -0,0 +1,184 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.plan.util
    +
    +import org.apache.calcite.plan.RelOptUtil
    +import org.apache.calcite.rex._
    +import org.apache.calcite.sql.{SqlFunction, SqlPostfixOperator}
    +import org.apache.flink.table.api.TableException
    +import org.apache.flink.table.calcite.FlinkTypeFactory
    +import org.apache.flink.table.expressions.{Expression, Literal, ResolvedFieldReference}
    +import org.apache.flink.table.validate.FunctionCatalog
    +import org.apache.flink.util.Preconditions
    +
    +import scala.collection.JavaConversions._
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable
    +import scala.util.{Failure, Success, Try}
    +
    +object RexProgramExtractor {
    +
    +  /**
    +    * Extracts the indices of input fields which accessed by the RexProgram.
    +    *
    +    * @param rexProgram The RexProgram to analyze
    +    * @return The indices of accessed input fields
    +    */
    +  def extractRefInputFields(rexProgram: RexProgram): Array[Int] = {
    +    val visitor = new InputRefVisitor
    +
    +    // extract referenced input fields from projections
    +    rexProgram.getProjectList.foreach(
    +      exp => rexProgram.expandLocalRef(exp).accept(visitor))
    +
    +    // extract referenced input fields from condition
    +    val condition = rexProgram.getCondition
    +    if (condition != null) {
    +      rexProgram.expandLocalRef(condition).accept(visitor)
    +    }
    +
    +    visitor.getFields
    +  }
    +
    +  /**
    +    * Extract condition from RexProgram and convert it into independent CNF expressions.
    +    *
    +    * @param rexProgram The RexProgram to analyze
    +    * @return converted expressions as well as RexNodes which cannot be translated
    +    */
    +  def extractConjunctiveConditions(
    +      rexProgram: RexProgram,
    +      rexBuilder: RexBuilder,
    +      catalog: FunctionCatalog): (Array[Expression], Array[RexNode]) = {
    +
    +    rexProgram.getCondition match {
    +      case condition: RexLocalRef =>
    +        val expanded = rexProgram.expandLocalRef(condition)
    +        // converts the expanded expression to conjunctive normal form,
    +        // like "(a AND b) OR c" will be converted to "(a OR c) AND (b OR c)"
    +        val cnf = RexUtil.toCnf(rexBuilder, expanded)
    +        // converts the cnf condition to a list of AND conditions
    +        val conjunctions = RelOptUtil.conjunctions(cnf)
    +
    +        val convertedExpressions = new mutable.ArrayBuffer[Expression]
    +        val unconvertedRexNodes = new mutable.ArrayBuffer[RexNode]
    +        val inputNames = rexProgram.getInputRowType.getFieldNames.asScala.toArray
    +        val converter = new ConvertToExpression(inputNames, catalog)
    +
    +        conjunctions.asScala.foreach(rex => {
    +          rex.accept(converter) match {
    +            case Some(expression) => convertedExpressions += expression
    +            case None => unconvertedRexNodes += rex
    +          }
    +        })
    +        (convertedExpressions.toArray, unconvertedRexNodes.toArray)
    +
    +      case _ => (Array.empty, Array.empty)
    +    }
    +  }
    +}
    +
    +/**
    +  * An RexVisitor to extract all referenced input fields
    +  */
    +class InputRefVisitor extends RexVisitorImpl[Unit](true) {
    +
    +  private var fields = mutable.LinkedHashSet[Int]()
    +
    +  def getFields: Array[Int] = fields.toArray
    +
    +  override def visitInputRef(inputRef: RexInputRef): Unit =
    +    fields += inputRef.getIndex
    +
    +  override def visitCall(call: RexCall): Unit =
    +    call.operands.foreach(operand => operand.accept(this))
    +}
    +
    +/**
    +  * An RexVisitor to convert RexNode to Expression.
    +  *
    +  * @param inputNames      The input names of the relation node
    +  * @param functionCatalog The function catalog
    +  */
    +class ConvertToExpression(
    --- End diff --
    
    Will change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---