Return-Path: <issues-return-99051-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id EA9EE200C28
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 13 Mar 2017 21:28:59 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id E9369160B6C; Mon, 13 Mar 2017 20:28:59 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 3D68A160B5D
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 13 Mar 2017 21:28:59 +0100 (CET)
Received: (qmail 6233 invoked by uid 500); 13 Mar 2017 20:28:58 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 6223 invoked by uid 99); 13 Mar 2017 20:28:58 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 20:28:58 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D74A61A0402
	for <issues@flink.apache.org>; Mon, 13 Mar 2017 20:28:57 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id uyNHYUT_6CoT for <issues@flink.apache.org>;
	Mon, 13 Mar 2017 20:28:57 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1D3745F5C4
	for <issues@flink.incubator.apache.org>; Mon, 13 Mar 2017 20:28:55 +0000 (UTC)
Received: (qmail 6210 invoked by uid 99); 13 Mar 2017 20:28:55 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 20:28:55 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 4AD00DFE61; Mon, 13 Mar 2017 20:28:55 +0000 (UTC)
From: sjwiesman <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3479-flink@git.apache.org>
In-Reply-To: <git-pr-3479-flink@git.apache.org>
Subject: [GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...
Content-Type: text/plain
Message-Id: <20170313202855.4AD00DFE61@git1-us-west.apache.org>
Date: Mon, 13 Mar 2017 20:28:55 +0000 (UTC)
archived-at: Mon, 13 Mar 2017 20:29:00 -0000

Github user sjwiesman commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3479#discussion_r105763162
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalAggregateProcessAllWindowFunction.java ---
    @@ -53,22 +57,47 @@ public InternalAggregateProcessAllWindowFunction(
     	}
     
     	@Override
    -	public void apply(Byte key, final W window, Iterable<T> input, Collector<R> out) throws Exception {
    +	public void open(Configuration parameters) throws Exception {
    +		super.open(parameters);
     		ProcessAllWindowFunction<V, R, W> wrappedFunction = this.wrappedFunction;
    -		ProcessAllWindowFunction<V, R, W>.Context context = wrappedFunction.new Context() {
    -			@Override
    -			public W window() {
    -				return window;
    -			}
    -		};
    +		this.ctx = new InternalProcessAllWindowContext<>(wrappedFunction);
    +	}
     
    +	@Override
    +	public void process(Byte aByte, final W window, final InternalWindowContext context, Iterable<T> input, Collector<R> out) throws Exception {
     		final ACC acc = aggFunction.createAccumulator();
     
     		for (T val : input) {
     			aggFunction.add(val, acc);
     		}
     
    -		wrappedFunction.process(context, Collections.singletonList(aggFunction.getResult(acc)), out);
    +		this.ctx.window = window;
    +		this.ctx.internalContext = context;
    +		ProcessAllWindowFunction<V, R, W> wrappedFunction = this.wrappedFunction;
    +		wrappedFunction.process(ctx, Collections.singletonList(aggFunction.getResult(acc)), out);
    +	}
    +
    +	@Override
    +	public void clear(final W window, final InternalWindowContext context) throws Exception {
    +		ProcessAllWindowFunction<V, R, W> wrappedFunction = this.wrappedFunction;
    +		final ProcessAllWindowFunction<V, R, W>.Context ctx = wrappedFunction.new Context() {
    --- End diff --
    
    whoops 😱 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---