Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: StephanEwen <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3466-flink@git.apache.org>
In-Reply-To: <git-pr-3466-flink@git.apache.org>
Subject: [GitHub] flink pull request #3466: [FLINK-5715] Asynchronous snapshots for heap-based...
Content-Type: text/plain
Message-Id: <20170309100839.01D17DFF56@git1-us-west.apache.org>
Date: Thu,  9 Mar 2017 10:08:39 +0000 (UTC)
archived-at: Thu, 09 Mar 2017 10:08:43 -0000

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3466#discussion_r105125855
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapListStateTest.java ---
    @@ -233,7 +231,8 @@ public void testMerging() throws Exception {
     				StringSerializer.INSTANCE,
     				HeapListStateTest.class.getClassLoader(),
     				16,
    -				new KeyGroupRange(0, 15));
    +				new KeyGroupRange(0, 15),
    +				(System.currentTimeMillis() & 1) == 1);
    --- End diff --
    
    Why not test both combinations here, rather than randomly one of the two?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---