Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: iemejia <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3494-flink@git.apache.org>
In-Reply-To: <git-pr-3494-flink@git.apache.org>
Subject: [GitHub] flink pull request #3494: [FLINK-5635] [docker] Improve Docker tooling
Content-Type: text/plain
Message-Id: <20170308123501.7156EDFBD3@git1-us-west.apache.org>
Date: Wed,  8 Mar 2017 12:35:01 +0000 (UTC)
archived-at: Wed, 08 Mar 2017 12:35:06 -0000

Github user iemejia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3494#discussion_r104907373
  
    --- Diff: flink-contrib/docker-flink/Dockerfile ---
    @@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
     EXPOSE 8081
     EXPOSE 6123
     
    +# flink-dist can point to a directory or a tarball on the local system
    +ARG flink_dist=NOT_SET
    +
     # Install build dependencies and flink
    +ADD $flink_dist $FLINK_INSTALL_PATH
     RUN set -x && \
    -  mkdir -p $FLINK_INSTALL_PATH && \
    -  apk --update add --virtual build-dependencies curl && \
    -  curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?preferred\=true)flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz | \
    --- End diff --
    
    We will break compatibility with docker hub if we move this out. Docker hub does not invoke a shell script but an specific Dockerfile hosted in a github repo, so this should not be done, or at least we should validate that we can build the image from docker hub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---