flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaqzcb <...@git.apache.org>
Subject [GitHub] flink pull request #3576: [FLINK-6132]Remove redundant code in CliFrontend.j...
Date Mon, 20 Mar 2017 16:24:55 GMT
GitHub user gaqzcb opened a pull request:

    https://github.com/apache/flink/pull/3576

    [FLINK-6132]Remove redundant code in CliFrontend.java

    
    
    Look at the switch case block in method parseParameters of CliFrontend.java.
    
    ```
    // do action
    switch (action) {
    case ACTION_RUN:
    return CliFrontend.this.run(params);
    case ACTION_LIST:
    return list(params);
    case ACTION_INFO:
    return info(params);
    case ACTION_CANCEL:
    return cancel(params);
    case ACTION_STOP:
    return stop(params);
    case ACTION_SAVEPOINT:
    return savepoint(params);
    ```
    
    It's better to change the first case return clause
    from:
    `return CliFrontend.this.run(params);`
    to:
    `return run(params);`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhengcanbin/flink FLINK-6132

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3576.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3576
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message