flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6162) Fix bug in ByteArrayOutputStreamWithPos#setPosition
Date Fri, 31 Mar 2017 15:41:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951157#comment-15951157
] 

ASF GitHub Bot commented on FLINK-6162:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3595
  
    @wenlong88 you are right that the position can currently be moved beyond written data.
This still feels a bit like feature creep as we've added to the PR. Do you need to expand
the array is this manner? How did you run across this bug? I'm not disagreeing with the change
but would like to be conservative and understand the why.


> Fix bug in ByteArrayOutputStreamWithPos#setPosition
> ---------------------------------------------------
>
>                 Key: FLINK-6162
>                 URL: https://issues.apache.org/jira/browse/FLINK-6162
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> Currently the precondition check in setPosition will fail when the buffer is full: 
> {{Preconditions.checkArgument(position < getEndPosition(), "Position out of bounds.");}}
> We should allow the expected position to be the end position



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message