flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6129) MetricRegistry does not stop query actor
Date Mon, 20 Mar 2017 17:15:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933091#comment-15933091
] 

ASF GitHub Bot commented on FLINK-6129:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3573#discussion_r106959941
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
    @@ -198,6 +204,14 @@ public boolean isShutdown() {
     	 * Shuts down this registry and the associated {@link MetricReporter}.
     	 */
     	public void shutdown() {
    +		Future<Boolean> stopFuture = null;
    --- End diff --
    
    why do you split the additions in 2 blocks? Could you not merge them with the sole condition
that the MQS is not null?


> MetricRegistry does not stop query actor
> ----------------------------------------
>
>                 Key: FLINK-6129
>                 URL: https://issues.apache.org/jira/browse/FLINK-6129
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.3.0
>
>
> The {{MetricRegistry}} does not properly close the started query actor upon shutdown.
This can be a resource leak.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message