flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams
Date Wed, 22 Mar 2017 13:30:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936308#comment-15936308
] 

ASF GitHub Bot commented on FLINK-6034:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3531#discussion_r107411558
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
---
    @@ -306,6 +307,29 @@ private static void assignTaskStatesToOperatorInstances(
     	}
     
     	/**
    +	 * Determine the subset of {@link KeyGroupsStateHandle KeyGroupsStateHandles} with correct
    +	 * key group index for the given subtask {@link KeyGroupRange}.
    +	 * <p>
    +	 * <p>This is publicly visible to be used in tests.
    +	 */
    +	public static List<KeyedStateHandle> getKeyedStateHandles(
    --- End diff --
    
    Could we completely remove `getKeyGroupsStateHandles()` and remove everything with this
method that works on `KeyedStateHandle`? This includes using also only `KeyedStateHandle`
for the raw keyed state that is checkpointed into streams (without backend). Otherwise, this
is almost duplicated code. What do you think?


> Add KeyedStateHandle for the snapshots in keyed streams
> -------------------------------------------------------
>
>                 Key: FLINK-6034
>                 URL: https://issues.apache.org/jira/browse/FLINK-6034
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Xiaogang Shi
>            Assignee: Xiaogang Shi
>
> Currently, the only type of the snapshots in keyed streams is {{KeyGroupsStateHandle}}
which is full and store the states one group after another. With the introduction of incremental
checkpointing, we need a higher level abstraction of keyed snapshots to allow flexible snapshot
formats. 
> The implementation of {{KeyedStateHandle}} s may vary a lot in different backends. The
only information needed in {{KeyedStateHandle}} s is their key group range. When recovering
the job with a different degree of parallelism, {{KeyedStateHandle}} s will be assigned to
those subtasks whose key group ranges overlap with their ranges.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message