flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5975) Mesos should support adding volumes to launched taskManagers
Date Tue, 14 Mar 2017 04:40:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923565#comment-15923565

ASF GitHub Bot commented on FLINK-5975:

Github user EronWright commented on a diff in the pull request:

    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
    @@ -259,9 +262,11 @@ public String toString() {
     				throw new IllegalStateException("unsupported container type");
     		if(containerInfo != null) {
    +			containerInfo.addAllVolumes(params.containerVolumes());
    --- End diff --
    There's an unnecessary restriction here, that volumes may be used only if a container
image is also used.   I bet you can use volumes with the Mesos containerizer without using
an image.     The code in the `case MESOS:` block should be reorganized to always set `containerInfo
= Protos.ContainerInfo.newBuilder()`.  This way, `containerInfo` will never be null.

> Mesos should support adding volumes to launched taskManagers
> ------------------------------------------------------------
>                 Key: FLINK-5975
>                 URL: https://issues.apache.org/jira/browse/FLINK-5975
>             Project: Flink
>          Issue Type: Improvement
>          Components: Mesos
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Addison Higham
>            Priority: Minor
> Flink needs access to shared storage.
> In many cases, this is HDFS, but it would be nice to also support file URIs on an mounted
NFS for example.
> Mesos exposes APIs for adding volumes, so it should be relatively simply to add this.
> As an example, here is the spark code for supporting volumes: https://github.com/apache/spark/blob/master/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala#L35

This message was sent by Atlassian JIRA

View raw message