flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5971) JobLeaderIdService should time out registered jobs
Date Thu, 09 Mar 2017 01:25:38 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902279#comment-15902279
] 

ASF GitHub Bot commented on FLINK-5971:
---------------------------------------

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3488#discussion_r105068068
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.configuration;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +
    +/**
    + * The set of configuration options relating to the ResourceManager
    + */
    +@PublicEvolving
    +public class ResourceManagerOptions {
    +
    +	public static final ConfigOption<String> JOB_TIMEOUT = ConfigOptions
    +		.key("resourcemanager.job.timeout")
    --- End diff --
    
    can we have a more specific name like "inactive_job.timeout". It looks like normal job
will also timeout for 5 minutes.


> JobLeaderIdService should time out registered jobs
> --------------------------------------------------
>
>                 Key: FLINK-5971
>                 URL: https://issues.apache.org/jira/browse/FLINK-5971
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> The {{JobLeaderIdService}} has no mechanism to time out inactive jobs. At the moment
it relies on the {{RunningJobsRegistry}} which only gives a heuristic answer.
> We should remove the {{RunningJobsRegistry}} and register instead a timeout for each
job which does not have a job leader associated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message