flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5963) Remove preparation mapper of DataSetAggregate
Date Sat, 04 Mar 2017 22:42:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895927#comment-15895927
] 

ASF GitHub Bot commented on FLINK-5963:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3472
  
    Hi @sunjincheng121, thanks for your review. I addressed you comments. 
    Cheers, Fabian


> Remove preparation mapper of DataSetAggregate
> ---------------------------------------------
>
>                 Key: FLINK-5963
>                 URL: https://issues.apache.org/jira/browse/FLINK-5963
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>
> With the new UDAGG interface we do not need the preparation mapper anymore. It adds overhead
because 
> - it is another operator
> - it prevents to use {{AggregateFunction.accumulate()}} in a combiner or reducer.
> Hence, it should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message