flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction
Date Sat, 04 Mar 2017 22:29:47 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895921#comment-15895921
] 

ASF GitHub Bot commented on FLINK-5956:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3470#discussion_r104298146
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
    @@ -23,10 +23,11 @@ import java.util.{List => JList}
     import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
     import org.apache.flink.api.java.tuple.{Tuple2 => JTuple2}
     import org.apache.flink.api.java.typeutils.TupleTypeInfo
    +import org.apache.flink.table.api.TableException
     import org.apache.flink.table.functions.{Accumulator, AggregateFunction}
     
     /** The initial accumulator for Sum aggregate function */
    -class SumAccumulator[T] extends JTuple2[T, Boolean] with Accumulator
    +class SumAccumulator[T] extends JTuple2[T, Long] with Accumulator
    --- End diff --
    
    I think we should also offer `SumAccumulator` with and without retraction. The difference
between `Long` and `Boolean` is 7 bytes, which is a lot of additional overhead for most types.


> Add retract method into the aggregateFunction
> ---------------------------------------------
>
>                 Key: FLINK-5956
>                 URL: https://issues.apache.org/jira/browse/FLINK-5956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> Retraction method is help for processing updated message. It will also very helpful for
window Aggregation. This PR will first add retraction methods into the aggregateFunctions,
such that on-going over window Aggregation can get benefit from it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message