flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction
Date Sun, 05 Mar 2017 00:40:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895987#comment-15895987
] 

ASF GitHub Bot commented on FLINK-5956:
---------------------------------------

Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3470#discussion_r104301022
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
    @@ -137,6 +146,15 @@ abstract class BigIntegralAvgAggFunction[T] extends AggregateFunction[T]
{
         }
       }
     
    +  override def retract(accumulator: Accumulator, value: Any): Unit = {
    --- End diff --
    
    I assume you are suggesting implement LongAvgAggFunction directly with JTuple2[BigInteger,
Long] as the accumulator, then yes, we could do that.


> Add retract method into the aggregateFunction
> ---------------------------------------------
>
>                 Key: FLINK-5956
>                 URL: https://issues.apache.org/jira/browse/FLINK-5956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> Retraction method is help for processing updated message. It will also very helpful for
window Aggregation. This PR will first add retraction methods into the aggregateFunctions,
such that on-going over window Aggregation can get benefit from it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message