flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction
Date Sun, 05 Mar 2017 00:37:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895986#comment-15895986
] 

ASF GitHub Bot commented on FLINK-5956:
---------------------------------------

Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3470#discussion_r104300989
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
    @@ -35,6 +36,18 @@ abstract class AggregateFunction[T] extends UserDefinedFunction {
       def createAccumulator(): Accumulator
     
       /**
    +    * Retract the input values from the accumulator instance.
    +    *
    +    * @param accumulator the accumulator which contains the current
    +    *                    aggregated results
    +    * @param input       the input value (usually obtained from a new arrived data)
    --- End diff --
    
    I think it should be ok to use "accumulator" here. Retract is a method, it retracts the
value from the accumulator.


> Add retract method into the aggregateFunction
> ---------------------------------------------
>
>                 Key: FLINK-5956
>                 URL: https://issues.apache.org/jira/browse/FLINK-5956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> Retraction method is help for processing updated message. It will also very helpful for
window Aggregation. This PR will first add retraction methods into the aggregateFunctions,
such that on-going over window Aggregation can get benefit from it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message