flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5941) Let handlers take part in job archiving
Date Thu, 02 Mar 2017 12:37:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892165#comment-15892165
] 

ASF GitHub Bot commented on FLINK-5941:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3444#discussion_r103903528
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/history/ArchivedJson.java
---
    @@ -0,0 +1,28 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.webmonitor.history;
    +
    +public class ArchivedJson {
    +	public final String path;
    +	public final String json;
    +	
    +	public ArchivedJson(String path, String json) {
    --- End diff --
    
    Could you add `checkNotNull` checks here? And we usually have getters instead of public
fields. Would be nice to follow that convention (of course opinions will differ about the
benefit of this). 


> Let handlers take part in job archiving
> ---------------------------------------
>
>                 Key: FLINK-5941
>                 URL: https://issues.apache.org/jira/browse/FLINK-5941
>             Project: Flink
>          Issue Type: New Feature
>          Components: Webfrontend
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.3.0
>
>
> The key idea behind the HistoryServer is to pre-compute all JSON responses which the
WebFrontend could request and store them as files in a directory structure resembling the
REST-API.
> For this require a mechanism to generate the responses and their corresponding REST URL.
> FLINK-5852 made it easier to re-use the JSON generation code, while FLINK-5870 made handlers
aware of the REST URLs that they are registered one.
> The aim of this JIRA is to extend job-related handlers, building on the above JIRAs,
enabling them to generate a number of (Path, Json) pairs for a given ExecutionGraph, containing
all responses that they could generate for the given graph and their respective REST URL..



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message