flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5941) Let handlers take part in job archiving
Date Thu, 02 Mar 2017 12:37:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892162#comment-15892162

ASF GitHub Bot commented on FLINK-5941:

Github user uce commented on a diff in the pull request:

    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
    @@ -424,6 +425,33 @@ protected void initChannel(SocketChannel ch) {
     		LOG.info("Web frontend listening at " + address + ':' + port);
    +	public static Archiver[] getArchivers() {
    --- End diff --
    What do you think about making this "dynamic" and moving it to the handlers. This would
of course only work if this method is not static (which should not be a problem if the JobManager
does the archiving).
    The handlers implement an interface:
    interface ArchivableJsonHandler {
      ArchivedJson[] createArchivedJsons(AccessExecutionGraph eg);
    The router helpers that register the handlers (`GET()`, etc.) check:
    if (handler instanceof ArchivableHandler) {
    This methods then bcomes:
    public Collection<ArchivableJsonHandler> getAchivableHanlders() {
      return archivable;

> Let handlers take part in job archiving
> ---------------------------------------
>                 Key: FLINK-5941
>                 URL: https://issues.apache.org/jira/browse/FLINK-5941
>             Project: Flink
>          Issue Type: New Feature
>          Components: Webfrontend
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.3.0
> The key idea behind the HistoryServer is to pre-compute all JSON responses which the
WebFrontend could request and store them as files in a directory structure resembling the
> For this require a mechanism to generate the responses and their corresponding REST URL.
> FLINK-5852 made it easier to re-use the JSON generation code, while FLINK-5870 made handlers
aware of the REST URLs that they are registered one.
> The aim of this JIRA is to extend job-related handlers, building on the above JIRAs,
enabling them to generate a number of (Path, Json) pairs for a given ExecutionGraph, containing
all responses that they could generate for the given graph and their respective REST URL..

This message was sent by Atlassian JIRA

View raw message