flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5940) ZooKeeperCompletedCheckpointStore cannot handle broken state handles
Date Fri, 10 Mar 2017 15:44:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905282#comment-15905282

ASF GitHub Bot commented on FLINK-5940:

Github user tillrohrmann commented on the issue:

    The mocking is indeed a little bit complex in this case. The problem is that you also
want to check that a state handle which fails to retrieve its state, is properly discarded.
This discard call happens as part of a callback to a ZooKeeper remove call. Since the curator
client uses the builder API to construct the ZooKeeper calls, it was necessary to mock all
the different build stages. I couldn't find a more succinct way to test this behaviour without
starting a ZooKeeper server.
    If you think it hurts the test's maintainability too much, then I can start a ZooKeeper
server for the test.

> ZooKeeperCompletedCheckpointStore cannot handle broken state handles
> --------------------------------------------------------------------
>                 Key: FLINK-5940
>                 URL: https://issues.apache.org/jira/browse/FLINK-5940
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
> The {{ZooKeeperCompletedCheckpointStore}} reads a set of {{RetrievableStateHandles}}
from ZooKeeper upon recovery. It then tries to retrieve the {{CompletedCheckpoint}} from the
latest state handle. If the retrieve operation fails, then the whole recovery of completed
checkpoints fails even though the store might have read older state handles from ZooKeeper.

> I propose to harden the behaviour by removing broken state handles and returning the
first successfully retrieved {{CompletedCheckpoint}}.

This message was sent by Atlassian JIRA

View raw message