flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5903) taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in YARN mode
Date Fri, 03 Mar 2017 10:42:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894104#comment-15894104

ASF GitHub Bot commented on FLINK-5903:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
    @@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor createDescriptor(String defaultApplicationN
     		if (cmd.hasOption(SLOTS.getOpt())) {
     			int slots = Integer.valueOf(cmd.getOptionValue(SLOTS.getOpt()));
    +		} else if (config.containsKey(ConfigConstants.YARN_VCORES)) {
    --- End diff --
    Actually, I'm not so sure whether whether we should use the `YARN_VCORES` value as a fallback
value for the number of task manager slots. We had this in the past but we changed it so that
the default behaviour is if the number of slots is not specified, then it is `1`. Changing
this here for Yarn would make the behaviour inconsistent wrt Mesos, for example. From a user's
perspective the old behaviour is imo more predictable. However, we should definitely respect
the configuration file settings for the task manager slots.

> taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in YARN mode
> ---------------------------------------------------------------------------------------
>                 Key: FLINK-5903
>                 URL: https://issues.apache.org/jira/browse/FLINK-5903
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>            Reporter: Tao Wang
>            Assignee: Tao Wang
>         Attachments: set taskmanager.numberOfTaskSlots to 6.JPG, set yarn.container.vcores
to 5_JM.JPG, set yarn.container.vcores to 5_RM.JPG
> Now Flink did not respect taskmanager.numberOfTaskSlots and yarn.containers.vcores in
flink-conf.yaml, but only -s parameter in CLI.
> Details is that taskmanager.numberOfTaskSlots is not working in anyway andyarn.containers.vcores
is only used in requesting container(TM) resources but not aware to TM, which means TM will
always think it has default(1) Slots if -s is not configured.

This message was sent by Atlassian JIRA

View raw message