flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.
Date Mon, 06 Mar 2017 13:40:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897283#comment-15897283
] 

ASF GitHub Bot commented on FLINK-5846:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3445#discussion_r104412825
  
    --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java
---
    @@ -73,7 +73,8 @@ public Integer getKey(Event value) throws Exception {
     					false,
     					keySelector,
     					IntSerializer.INSTANCE,
    -					new NFAFactory()),
    +					new NFAFactory(),
    +					true),
    --- End diff --
    
    Should this be `false`? The parameter name is `migratingFromOldKeyedOperator`.
    
    Same for the other instances in this file.


> CEP: make the operators backwards compatible.
> ---------------------------------------------
>
>                 Key: FLINK-5846
>                 URL: https://issues.apache.org/jira/browse/FLINK-5846
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>    Affects Versions: 1.3.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.3.0
>
>
> This targets making the new CEP operators compatible with their previous versions from
Flink 1.1 and Flink 1.2.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message