flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5829) Bump Calcite version to 1.12 once available
Date Sat, 25 Mar 2017 08:08:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941637#comment-15941637

Haohui Mai commented on FLINK-5829:

I just pushed a PR. The migration process is relatively straightforward except that Calcite
1.12 seems to be conflicted with FLINK-4288.

The {{tableMap}} field has become a protected member thus unregister table become non-trivial.
There are two options here.

1. Revert FLINK-4288. FLINK-4288 has not been released yet thus it is okay to pull it back
with no concerns on backward compatibility.
2. Implement a proxy schema which inherits from {{CalciteSchema}} to regain the access of
the field.

[~fhueske] [~twalthr], what do you think?

> Bump Calcite version to 1.12 once available
> -------------------------------------------
>                 Key: FLINK-5829
>                 URL: https://issues.apache.org/jira/browse/FLINK-5829
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Haohui Mai
> Once Calcite 1.12 is release we should update to remove some copied classes. 

This message was sent by Atlassian JIRA

View raw message