flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding
Date Mon, 06 Mar 2017 12:19:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897189#comment-15897189
] 

ASF GitHub Bot commented on FLINK-5824:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3468
  
    I'm in favor of using ```ConfigConstants.DEFAULT_CHARSET```. Using ```ConfigConstants.UTF_8```
does not imply in any way that this is the default that anyone should use; it would be equivalent
to using ```StandardCharsets.UTF_8```.


> Fix String/byte conversions without explicit encoding
> -----------------------------------------------------
>
>                 Key: FLINK-5824
>                 URL: https://issues.apache.org/jira/browse/FLINK-5824
>             Project: Flink
>          Issue Type: Bug
>          Components: Python API, Queryable State, State Backends, Checkpointing, Webfrontend
>            Reporter: Ufuk Celebi
>            Assignee: Dawid Wysakowicz
>            Priority: Blocker
>
> In a couple of places we convert Strings to bytes and bytes back to Strings without explicitly
specifying an encoding. This can lead to problems when client and server default encodings
differ.
> The task of this JIRA is to go over the whole project and look for conversions where
we don't specify an encoding and fix it to specify UTF-8 explicitly.
> For starters, we can {{grep -R 'getBytes()' .}}, which already reveals many problematic
places.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message