flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath
Date Mon, 06 Mar 2017 14:10:32 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897366#comment-15897366
] 

ASF GitHub Bot commented on FLINK-5778:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3442#discussion_r104420885
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/AbstractSavepointSerializer.java
---
    @@ -0,0 +1,386 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.checkpoint.savepoint;
    +
    +import java.io.DataInputStream;
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.runtime.checkpoint.SubtaskState;
    +import org.apache.flink.runtime.checkpoint.TaskState;
    +import org.apache.flink.runtime.jobgraph.JobVertexID;
    +import org.apache.flink.runtime.state.ChainedStateHandle;
    +import org.apache.flink.runtime.state.KeyGroupRange;
    +import org.apache.flink.runtime.state.KeyGroupRangeOffsets;
    +import org.apache.flink.runtime.state.KeyGroupsStateHandle;
    +import org.apache.flink.runtime.state.OperatorStateHandle;
    +import org.apache.flink.runtime.state.StreamStateHandle;
    +import org.apache.flink.runtime.state.filesystem.FileStateHandle;
    +import org.apache.flink.runtime.state.memory.ByteStreamStateHandle;
    +
    +/**
    + * Abstract Serializer for {@link Savepoint} instances.
    + *
    + * <p>This is based on the {@link SavepointV1Serializer} of Flink 1.2.0 that
    + * makes sure no default Java serialization is used.
    + *
    + * <p>The abstract class allows to overwrite the serialization behaviour for
    + * {@link FileStateHandle} instances. This is the only practical difference
    + * between Flink 1.2.x and versions >= Flink 1.3.0.
    + *
    + * <p>This will probably be extended in ways that I cannot imagine at this point
    + * in time. If for whatever reason the abstract base class turns out to be a
    + * bad idea, feel free to change stuff. Right now, it's sole purpose is reducing
    + * code duplication between {@link SavepointV1Serializer} and {@link SavepointV2Serializer}.
    + */
    +abstract class AbstractSavepointSerializer<T extends Savepoint> implements SavepointSerializer<T>
{
    --- End diff --
    
    Agreed, let me change this.


> Split FileStateHandle into fileName and basePath
> ------------------------------------------------
>
>                 Key: FLINK-5778
>                 URL: https://issues.apache.org/jira/browse/FLINK-5778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> Store the statePath as a basePath and a fileName and allow to overwrite the basePath.
We cannot overwrite the base path as long as the state handle is still in flight and not persisted.
Otherwise we risk a resource leak.
> We need this in order to be able to relocate savepoints.
> {code}
> interface RelativeBaseLocationStreamStateHandle {
>    void clearBaseLocation();
>    void setBaseLocation(String baseLocation);
> }
> {code}
> FileStateHandle should implement this and the SavepointSerializer should forward the
calls when a savepoint is stored or loaded, clear before store and set after load.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message