flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath
Date Wed, 01 Mar 2017 14:06:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890229#comment-15890229
] 

ASF GitHub Bot commented on FLINK-5778:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3442#discussion_r103689657
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java
---
    @@ -0,0 +1,109 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.checkpoint.savepoint;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +import java.io.DataInputStream;
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +import java.net.URI;
    +import java.util.Collection;
    +import javax.annotation.Nullable;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.runtime.checkpoint.TaskState;
    +import org.apache.flink.runtime.state.filesystem.FileStateHandle;
    +
    +/**
    + * A savepoint serializer that does not store absolute URIs for {@link FileStateHandle}
    + * instances, allowing users to relocate savepoints as long as the file structure
    + * within the savepoint directory stays the same.
    + */
    +class SavepointV2Serializer extends AbstractSavepointSerializer<SavepointV2> {
    +
    +	public static final SavepointV2Serializer INSTANCE = new SavepointV2Serializer();
    +
    +	private SavepointV2Serializer() {
    +	}
    +
    +	@Override
    +	SavepointV2 createSavepoint(long checkpointId, Collection<TaskState> taskStates)
{
    +		return new SavepointV2(checkpointId, taskStates);
    +	}
    +
    +	@Override
    +	void serializeFileStreamStateHandle(FileStateHandle fileStateHandle, Path basePath,
DataOutputStream dos) throws IOException {
    --- End diff --
    
    Here is the new serialization behaviour


> Split FileStateHandle into fileName and basePath
> ------------------------------------------------
>
>                 Key: FLINK-5778
>                 URL: https://issues.apache.org/jira/browse/FLINK-5778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> Store the statePath as a basePath and a fileName and allow to overwrite the basePath.
We cannot overwrite the base path as long as the state handle is still in flight and not persisted.
Otherwise we risk a resource leak.
> We need this in order to be able to relocate savepoints.
> {code}
> interface RelativeBaseLocationStreamStateHandle {
>    void clearBaseLocation();
>    void setBaseLocation(String baseLocation);
> }
> {code}
> FileStateHandle should implement this and the SavepointSerializer should forward the
calls when a savepoint is stored or loaded, clear before store and set after load.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message