flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5758) Port-range for the web interface via YARN
Date Fri, 03 Mar 2017 10:11:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894063#comment-15894063
] 

ASF GitHub Bot commented on FLINK-5758:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3391#discussion_r103203690
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
    @@ -414,19 +410,36 @@ protected void initChannel(SocketChannel ch) {
     		NioEventLoopGroup bossGroup   = new NioEventLoopGroup(1);
     		NioEventLoopGroup workerGroup = new NioEventLoopGroup();
     
    +
    +		final String configuredAddress = cfg.getWebFrontendAddress();
    +		final Iterator<Integer> configuredPortRange = cfg.getWebFrontendPortRange();
    +
     		this.bootstrap = new ServerBootstrap();
     		this.bootstrap
     				.group(bossGroup, workerGroup)
     				.channel(NioServerSocketChannel.class)
     				.childHandler(initializer);
     
    -		ChannelFuture ch;
    -		if (configuredAddress == null) {
    -			ch = this.bootstrap.bind(configuredPort);
    -		} else {
    -			ch = this.bootstrap.bind(configuredAddress, configuredPort);
    +
    +		try {
    +			this.serverChannel = NetUtils.createServerFromPorts(configuredAddress, configuredPortRange,
new NetUtils.ServerFactory<Channel>() {
    +				@Override
    +				public Channel create(String address, int port) throws Exception {
    +					ChannelFuture ch;
    +					if (address == null) {
    +						ch = bootstrap.bind(port);
    +					} else {
    +						ch = bootstrap.bind(address, port);
    +						LOG.info("Web frontend listening at configuredAddress " + address );
    +					}
    +
    +					return ch.sync().channel();
    +				}
    +			});
    +		} catch (Exception e) {
    +			throw new BindException(e.getMessage());
    --- End diff --
    
    Not sure whether all exceptions which you're catching here should be packed in a `BindException`.
For example, what happens if you catch the `InterruptedException` here which can originate
from `ch.sync()`?


> Port-range for the web interface via YARN
> -----------------------------------------
>
>                 Key: FLINK-5758
>                 URL: https://issues.apache.org/jira/browse/FLINK-5758
>             Project: Flink
>          Issue Type: Sub-task
>          Components: YARN
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0
>            Reporter: Kanstantsin Kamkou
>            Assignee: Yelei Feng
>              Labels: network
>
> In case of YARN, the {{ConfigConstants.JOB_MANAGER_WEB_PORT_KEY}}   [is changed to 0|https://github.com/apache/flink/blob/release-1.2.0/flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java#L526].
Please allow port ranges in this case. DevOps need that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message