flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5698) Add NestedFieldsProjectableTableSource interface
Date Thu, 02 Mar 2017 16:11:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892475#comment-15892475
] 

ASF GitHub Bot commented on FLINK-5698:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3269#discussion_r103918266
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/util/RexProgramProjectExtractor.scala
---
    @@ -84,6 +108,49 @@ object RexProgramProjectExtractor {
     }
     
     /**
    +  * A RexVisitor to extract used nested input fields
    +  */
    +class RefFieldAccessorVisitor(
    +    names: List[String],
    +    usedFields: Array[Int]) extends RexVisitorImpl[Unit](true) {
    +
    +  private val projectedFields = new util.ArrayList[Array[String]]
    +
    +  names.foreach { n =>
    +    projectedFields.add(Array.empty)
    +  }
    +
    +  private val order: Map[Int, Int] = names.indices.zip(usedFields).map(_.swap).toMap
    --- End diff --
    
    `names` and `usedFields` might not have the same length.
    The result of `zip` has the length of the smaller of both lists which is not intended
here, right?


> Add NestedFieldsProjectableTableSource interface
> ------------------------------------------------
>
>                 Key: FLINK-5698
>                 URL: https://issues.apache.org/jira/browse/FLINK-5698
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Anton Solovev
>            Assignee: Anton Solovev
>
> Add a NestedFieldsProjectableTableSource interface for some TableSource implementation
that support nesting projection push-down.
> The interface could look as follows
> {code}
> def trait NestedFieldsProjectableTableSource {
>   def projectNestedFields(fields: Array[String]): NestedFieldsProjectableTableSource[T]
> }
> {code}
> This interface works together with ProjectableTableSource 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message